[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612559#comment-14612559
]
ASF GitHub Bot commented on FLINK-1520:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-118173012
Hi @shghatge! Thank you for the update :)
I left some comments inline. There are still some formatting issues in the
code. Please, carefully go through your changes and try to be consistent. Also,
there are still several warning regarding types, unused annotations, unused
variables. Can you please try to remove them? Your IDE should have a setting
that gives you the list of warnings.
Regarding the tests, better create new test files for your methods, since
you need to test with files and currently other tests use `collect()`.
Finally, I find the `types()` methods a bit confusing. Could we maybe have
separate types methods for the vertices and edges? e.g. `typesEdges(keyType,
valueType)`, `typesEdges(keyType)`, `typesVertices(keyType, valueType)` and
`typesVertices(keyType)`?
> Read edges and vertices from CSV files
> --------------------------------------
>
> Key: FLINK-1520
> URL: https://issues.apache.org/jira/browse/FLINK-1520
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Shivani Ghatge
> Priority: Minor
> Labels: easyfix, newbie
>
> Add methods to create Vertex and Edge Datasets directly from CSV file inputs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
