[
https://issues.apache.org/jira/browse/FLINK-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352167#comment-16352167
]
ASF GitHub Bot commented on FLINK-6571:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5394
How about calling `Thread.currentThread().interrupt();` only after having
left the loop?
```
public void run(SourceContext<T> ctx) throws Exception {
boolean setInterruptFlag = false;
while (running) {
try {
Thread.sleep(20);
} catch (InterruptedException ignored) {
setInterruptFlag = true;
}
}
if (setInterruptFlag) {
Thread.currentThread().interrupt();
}
}
```
This should behave like the original proposal, without the hot loop.
> InfiniteSource in SourceStreamOperatorTest should deal with
> InterruptedExceptions
> ---------------------------------------------------------------------------------
>
> Key: FLINK-6571
> URL: https://issues.apache.org/jira/browse/FLINK-6571
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.3.0, 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Labels: test-stability
> Fix For: 1.5.0
>
>
> So this is a new one: i got a failing test
> ({{testNoMaxWatermarkOnAsyncStop}}) due to an uncatched InterruptedException.
> {code}
> [00:28:15] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 0.828 sec <<< FAILURE! - in
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest
> [00:28:15]
> testNoMaxWatermarkOnAsyncStop(org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest)
> Time elapsed: 0 sec <<< ERROR!
> [00:28:15] java.lang.InterruptedException: sleep interrupted
> [00:28:15] at java.lang.Thread.sleep(Native Method)
> [00:28:15] at
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest$InfiniteSource.run(StreamSourceOperatorTest.java:343)
> [00:28:15] at
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:87)
> [00:28:15] at
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest.testNoMaxWatermarkOnAsyncStop(StreamSourceOperatorTest.java:176)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
