Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-118173012
Hi @shghatge! Thank you for the update :)
I left some comments inline. There are still some formatting issues in the
code. Please, carefully go through your changes and try to be consistent. Also,
there are still several warning regarding types, unused annotations, unused
variables. Can you please try to remove them? Your IDE should have a setting
that gives you the list of warnings.
Regarding the tests, better create new test files for your methods, since
you need to test with files and currently other tests use `collect()`.
Finally, I find the `types()` methods a bit confusing. Could we maybe have
separate types methods for the vertices and edges? e.g. `typesEdges(keyType,
valueType)`, `typesEdges(keyType)`, `typesVertices(keyType, valueType)` and
`typesVertices(keyType)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
