Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5400#discussion_r165930338
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java 
---
    @@ -184,6 +184,18 @@
                        key("taskmanager.network.detailed-metrics")
                        .defaultValue(false);
     
    +   /**
    +    * Config parameter defining whether to spill data for channels with 
barrier or not in exactly-once
    +    * mode based on credit-based flow control.
    +    *
    +    * @deprecated Will be removed for Flink 1.6 when the old code will be 
dropped in favour of
    +    * credit-based flow control.
    +    */
    +   @Deprecated
    +   public static final ConfigOption<Boolean> 
EXACTLY_ONCE_BLOCKING_DATA_ENABLED =
    +                   key("taskmanager.exactly-once.blocking.data.enabled")
    +                   .defaultValue(false);
    --- End diff --
    
    I think we would like to enable it by default and leave this config option 
just as a safety net in case of bugs/problems.
    
    btw, shouldn't this be tightly coupled with a credit based flow switch?


---

Reply via email to