[
https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355190#comment-16355190
]
ASF GitHub Bot commented on FLINK-8516:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5393
@tweise ok, I think I can agree on your last comment.
> Should I add a (trivial) unit test that asserts that
isThisSubtaskShouldSubscribeTo applies modulus to assigner returned value that
falls outside the subtask index range?
That sounds good! Once we add that, I think we're good to go.
> FlinkKinesisConsumer does not balance shards over subtasks
> ----------------------------------------------------------
>
> Key: FLINK-8516
> URL: https://issues.apache.org/jira/browse/FLINK-8516
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
>
> The hash code of the shard is used to distribute discovered shards over
> subtasks round robin. This works as long as shard identifiers are sequential.
> After shards are rebalanced in Kinesis, that may no longer be the case and
> the distribution become skewed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
