Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5418#discussion_r166564479
--- Diff:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
---
@@ -94,4 +96,22 @@ public void close() {
client.dispatcher().executorService().shutdown();
client.connectionPool().evictAll();
}
+
+ private static class EmptyCallback implements Callback {
+ private static final EmptyCallback singleton = new
EmptyCallback();
+
+ public static Callback getEmptyCallback() {
+ return singleton;
+ }
+
+ @Override
+ public void onFailure(Call call, IOException e) {
+ // Do nothing
--- End diff --
Let's log the exception at least as DEBUG.
---
