[
https://issues.apache.org/jira/browse/FLINK-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355337#comment-16355337
]
ASF GitHub Bot commented on FLINK-8575:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5422
[FLINK-8575][runtime] BackPressureStatsTrackerITCase unstable
## What is the purpose of the change
*This fixes BackPressureStatsTrackerITCase unstability.*
## Brief change log
- *Add missing synchronization in BackPressureStatsTracker. Operations in
method getOperatorBackPressureStats must appear atomic otherwise the stack
trace can be sampled multiple times.*
## Verifying this change
This change is already covered by existing tests, such as
*BackPressureStatsTrackerITCase*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-8575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5422.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5422
----
commit 8c2b005b90631f7dd818a5d8a06400d5cebc83d7
Author: gyao <gary@...>
Date: 2018-02-07T11:25:35Z
[FLINK-8575][runtime] Add missing synchronization in
BackPressureStatsTracker
Operations in method getOperatorBackPressureStats must appear atomic
otherwise
the stack trace can be sampled multiple times.
----
> BackPressureStatsTrackerITCase unstable
> ---------------------------------------
>
> Key: FLINK-8575
> URL: https://issues.apache.org/jira/browse/FLINK-8575
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Gary Yao
> Priority: Critical
> Labels: test-stability
>
> https://travis-ci.org/apache/flink/jobs/338212141
> https://travis-ci.org/apache/flink/jobs/338277291
> {code}
> testBackPressuredProducer(org.apache.flink.runtime.rest.handler.legacy.backpressure.BackPressureStatsTrackerITCase)
> Time elapsed: 11.426 sec <<< FAILURE!
> java.lang.AssertionError: expected:<10> but was:<9>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.runtime.rest.handler.legacy.backpressure.BackPressureStatsTrackerITCase$1$1.run(BackPressureStatsTrackerITCase.java:239)
> at akka.testkit.JavaTestKit$Within$1.apply(JavaTestKit.java:246)
> at akka.testkit.TestKitBase$class.within(TestKit.scala:345)
> at akka.testkit.TestKit.within(TestKit.scala:814)
> at akka.testkit.TestKitBase$class.within(TestKit.scala:359)
> at akka.testkit.TestKit.within(TestKit.scala:814)
> at akka.testkit.JavaTestKit$Within.<init>(JavaTestKit.java:243)
> at
> org.apache.flink.runtime.rest.handler.legacy.backpressure.BackPressureStatsTrackerITCase$1$1.<init>(BackPressureStatsTrackerITCase.java:151)
> at
> org.apache.flink.runtime.rest.handler.legacy.backpressure.BackPressureStatsTrackerITCase$1.<init>(BackPressureStatsTrackerITCase.java:151)
> at
> org.apache.flink.runtime.rest.handler.legacy.backpressure.BackPressureStatsTrackerITCase.testBackPressuredProducer(BackPressureStatsTrackerITCase.java:96)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
