[ https://issues.apache.org/jira/browse/FLINK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357086#comment-16357086 ]
ASF GitHub Bot commented on FLINK-8608: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5431 [FLINK-8608] [flip6] Implement MiniDispatcher for job mode ## What is the purpose of the change The MiniDispatcher is responsible for submitting the single job with which a job mode cluster is started. Once the job has completed and if the cluster has been started in detached mode, the MiniDispatcher will terminate. In order to reduce code duplication, the MiniDispatcher is a sub class of the Dispatcher which is started with a single job submitted job graph store. ## Brief change log - Introduce `SingleJobSubmittedJobGraphStore` for the `MiniDispatcher` - Refactored `JobClusterEntrypoint` and `SessionClusterEntrypoint` such that most of the cluster component logic moved to `ClusterEntrypoint` - Renamed `JobMasterRestEndpoint` into `MiniDispatcherRestEndpoint` - Initialize `MiniDispatcher` with single job retrieved by the `JobClusterEntrypoint` - Terminate `MiniDispatcher` after job completion if the its execution mode is `detached` ## Verifying this change - Added `MiniDispatcherTest` - The tests of `MiniDispatcher` are also valid for the `MiniDispatcher` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink implementMiniDispatcher Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5431.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5431 ---- commit db57b574b0a2bacfa5aa164082c1eeb8f5258ed8 Author: Till Rohrmann <trohrmann@...> Date: 2018-02-08T13:34:54Z [FLINK-8608] [flip6] Implement MiniDispatcher for job mode The MiniDispatcher is responsible for submitting the single job with which a job mode cluster is started. Once the job has completed and if the cluster has been started in detached mode, the MiniDispatcher will terminate. In order to reduce code duplication, the MiniDispatcher is a sub class of the Dispatcher which is started with a single job submitted job graph store. ---- > Add MiniDispatcher for job mode > ------------------------------- > > Key: FLINK-8608 > URL: https://issues.apache.org/jira/browse/FLINK-8608 > Project: Flink > Issue Type: New Feature > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to properly support the job mode, we need a {{MiniDispatcher}} which > is started with a pre initialized {{JobGraph}} and launches a single > {{JobManagerRunner}} with this job. Once the job is completed and if the > {{MiniDispatcher}} is running in detached mode, the {{MiniDispatcher}} should > terminate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)