[ 
https://issues.apache.org/jira/browse/FLINK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357130#comment-16357130
 ] 

ASF GitHub Bot commented on FLINK-8610:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5433

    [FLINK-8610] [flip6] Remove RestfulGateway from JobMasterGateway

    ## What is the purpose of the change
    
    The JobMaster no longer needs to implement the RestfulGateway. Therefore,
    it is removed by this commit.
    
    This PR is based on #5431.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink 
removeRestfulGatewayFromJobMaster

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5433
    
----
commit db57b574b0a2bacfa5aa164082c1eeb8f5258ed8
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-08T13:34:54Z

    [FLINK-8608] [flip6] Implement MiniDispatcher for job mode
    
    The MiniDispatcher is responsible for submitting the single job with which
    a job mode cluster is started. Once the job has completed and if the cluster
    has been started in detached mode, the MiniDispatcher will terminate.
    
    In order to reduce code duplication, the MiniDispatcher is a sub class of 
the
    Dispatcher which is started with a single job submitted job graph store.

commit 1da4fa2dab9c7e6ab6aecfe5c8512de217fcce9a
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-07T10:09:34Z

    [FLINK-8610] [flip6] Remove RestfulGateway from JobMasterGateway
    
    The JobMaster no longer needs to implement the RestfulGateway. Therefore,
    it is removed by this commit.

----


> Remove RestfulGateway from JobMasterGateway
> -------------------------------------------
>
>                 Key: FLINK-8610
>                 URL: https://issues.apache.org/jira/browse/FLINK-8610
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> After adding FLINK-8608, the {{JobMaster}} no longer needs to implement the 
> {{RestfulGateway}}. Therefore, we should remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to