[
https://issues.apache.org/jira/browse/FLINK-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357843#comment-16357843
]
ASF GitHub Bot commented on FLINK-8617:
---------------------------------------
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5438
[FLINK-8617][TableAPI & SQL] Fix code generation bug while accessing …
## What is the purpose of the change
fix code generation error in MapGet
## Brief change log
handle nullTerm of MapGet GeneratedExpression correctly.
## Verifying this change
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
```
run org.apache.flink.table.runtime.batch.sql.CalcITCase testMapGet()
run org.apache.flink.table.runtime.batch.table.CalcITCase testMapget()
run org.apache.flink.table.runtime.stream.table.CalcITCase testMapGet()
run org.apache.flink.table.runtime.stream.sql.SqlITCase testMapGet()
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency):
no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`:
no
- The serializers:
no
- The runtime per-record code paths (performance sensitive):
no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper:
no
- The S3 file system connector:
no
## Documentation
- Does this pull request introduce a new feature?
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xpray/flink FLINK-8617
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5438
----
commit d618aac64156a9fd86c8367d6594e593521a8d8b
Author: Xpray <leonxpray@...>
Date: 2018-02-09T02:17:16Z
[FLINK-8617][TableAPI & SQL] Fix code generation bug while accessing Map
type
----
> Fix code generation bug while accessing Map type
> ------------------------------------------------
>
> Key: FLINK-8617
> URL: https://issues.apache.org/jira/browse/FLINK-8617
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
> Priority: Major
>
> There's a code generation bug in {code}ScalarOperatos.generateMapGet{code}.
> And there's two more bugs found in {code}ScalarOperators.generateIsNull{code}
> and {code}ScalarOperators.generateIsNotNull{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
