ASF GitHub Bot commented on FLINK-6160:

GitHub user zhangminglei opened a pull request:


    [FLINK-6160] [flip-6] Retry JobManager/ResourceManager connection in …

    ## What is the purpose of the change
    When timeout comes, retry JobManager/ResourceManager connection in case of 
    ## Brief change log
    When timeout, invoke ```requestHeartbeat``` in HeartbeatMonitor thread. Not 
directly invoke ```notifyHeartbeatTimeout``` and close the connection.
    ## Verifying this change
    This change is already covered by existing tests, but did minor changes. in 
the TaskExecutorTest.java, change ```testHeartbeatTimeoutWithResourceManager``` 
behavior to while timeout, does not invoke ```disconnectTaskManager```.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): ( don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-6160

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5440
commit 5319abdf503c757baf7afde9913ab2fb6fb61b60
Author: zhangminglei <zml13856086071@...>
Date:   2018-02-09T11:52:50Z

    [FLINK-6160] [flip-6] Retry JobManager/ResourceManager connection in case 
of timeout


>  Retry JobManager/ResourceManager connection in case of timeout
> ---------------------------------------------------------------
>                 Key: FLINK-6160
>                 URL: https://issues.apache.org/jira/browse/FLINK-6160
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
> In case of a heartbeat timeout, the {{TaskExecutor}} closes the connection to 
> the remote component. Furthermore, it assumes that the component has actually 
> failed and, thus, it will only start trying to connect to the component if it 
> is notified about a new leader address and leader session id. This is 
> brittle, because the heartbeat could also time out without the component 
> having crashed. Thus, we should add an automatic retry to the latest known 
> leader address information in case of a timeout.

This message was sent by Atlassian JIRA

Reply via email to