[ 
https://issues.apache.org/jira/browse/FLINK-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358780#comment-16358780
 ] 

ASF GitHub Bot commented on FLINK-8627:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5445

    [FLINK-8627] Introduce new JobStatus#SUSPENDING

    ## What is the purpose of the change
    
    The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended 
but its
    clean up has not been done yet. Only after all Executions have been 
canceled, the
    ExecutionGraph will enter the SUSPENDED state and complete the termination 
future
    accordingly.
    
    ## Brief change log
    
    - Rename `JobStatus#SUSPENDED` into `JobStatus#SUSPENDING`
    - Introduce new `JobStatus#SUSPENDED`
    - Only go into `JobStatus#SUSPENDED` from `JobStatus#SUSPENDING` once we 
have cancelled all `Executions`
    
    ## Verifying this change
    
    - Updated `ExecutionGraphSuspendTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink 
executionGraphTerminationFuture

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5445
    
----
commit ffc9edd8f41c4a8508170580f945c5b9ed911d01
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-01T13:37:15Z

    [hotfix] Fix checkstyle violations in ExecutionGraph

commit 38006cfd9fef14fa4aa0dc23cb6a4e4afd019006
Author: Till Rohrmann <trohrmann@...>
Date:   2018-02-01T17:04:06Z

    [FLINK-8627] Introduce new JobStatus#SUSPENDING
    
    The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended 
but its
    clean up has not been done yet. Only after all Executions have been 
canceled, the
    ExecutionGraph will enter the SUSPENDED state and complete the termination 
future
    accordingly.

----


> Introduce SUSPENDING state
> --------------------------
>
>                 Key: FLINK-8627
>                 URL: https://issues.apache.org/jira/browse/FLINK-8627
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>             Fix For: 1.5.0
>
>
> In order to better distinguish between an ongoing clean up operation and a 
> terminal state of the {{ExecutionGraph}}, I propose to introduce a 
> {{SUSPENDING}} state which says that the {{ExecutionGraph}} has been 
> suspended but the clean up has not been done yet. Only after all 
> {{Executions}} have been canceled the {{ExecutionGraph}} should enter the 
> {{SUSPENDED}} state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to