Fabian Hueske commented on FLINK-8538:

Hi, I agree with [~twalthr]. This looks mostly good, but we shouldn't add a new 
module. Also, it would be good to implement the code in Java as the project 
tries to reduce its dependency on Scala.

How about the following?
* the Kafka descriptor -> flink-connector-kafka-base
* a format independent (but version specific) KafkaTableSource -> 
* format and version specific TableSourceFactories -> 
* service discovery files -> flink-connector-kafka*version*

The format and version specific TableSourceFactories will be replaced by format 
independent factories once the format factory infrastructure is in place.
We can also go for version specific descriptors, if that makes more sense.
Since most of the changes would be in version-specific modules, I'd start with 
one module first (Kafka 0.11) and port the change later to earlier versions 
once we agreed on the interfaces. Version independent code can also be 
extracted into abstract classes in flink-connector-kafka-base. 

> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>                 Key: FLINK-8538
>                 URL: https://issues.apache.org/jira/browse/FLINK-8538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should 
> be added. This issue includes improving the existing JSON descriptor with 
> validation that can be used for other connectors as well. It is up for 
> discussion if we want to split the KafkaJsonTableSource into connector and 
> format such that we can reuse the format for other table sources as well.

This message was sent by Atlassian JIRA

Reply via email to