Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5400#discussion_r167557594
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java
 ---
    @@ -18,1426 +18,40 @@
     
     package org.apache.flink.streaming.runtime.io;
     
    -import org.apache.flink.core.memory.MemorySegment;
    -import org.apache.flink.core.memory.MemorySegmentFactory;
    -import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
    -import org.apache.flink.runtime.checkpoint.CheckpointMetrics;
    -import org.apache.flink.runtime.checkpoint.CheckpointOptions;
    -import 
org.apache.flink.runtime.checkpoint.decline.CheckpointDeclineOnCancellationBarrierException;
    -import 
org.apache.flink.runtime.checkpoint.decline.CheckpointDeclineSubsumedException;
     import org.apache.flink.runtime.io.disk.iomanager.IOManager;
     import org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync;
    -import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
    -import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
    -import org.apache.flink.runtime.io.network.api.EndOfPartitionEvent;
    -import org.apache.flink.runtime.io.network.buffer.Buffer;
    -import org.apache.flink.runtime.io.network.buffer.FreeingBufferRecycler;
    -import org.apache.flink.runtime.io.network.buffer.NetworkBuffer;
     import 
org.apache.flink.runtime.io.network.partition.consumer.BufferOrEvent;
    -import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
    -import org.apache.flink.runtime.operators.testutils.DummyEnvironment;
    +import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
     
    -import org.hamcrest.BaseMatcher;
    -import org.hamcrest.Description;
    +import org.junit.After;
     import org.junit.AfterClass;
     import org.junit.BeforeClass;
    -import org.junit.Test;
     
     import java.io.File;
    -import java.util.Arrays;
    -import java.util.Random;
    +import java.io.IOException;
     
     import static org.junit.Assert.assertEquals;
    -import static org.junit.Assert.assertNotNull;
    -import static org.junit.Assert.assertNull;
    -import static org.junit.Assert.assertTrue;
     import static org.junit.Assert.fail;
    -import static org.mockito.Matchers.any;
    -import static org.mockito.Matchers.anyLong;
    -import static org.mockito.Matchers.argThat;
    -import static org.mockito.Matchers.eq;
    -import static org.mockito.Mockito.mock;
    -import static org.mockito.Mockito.times;
    -import static org.mockito.Mockito.verify;
     
     /**
    - * Tests for the behavior of the {@link BarrierBuffer}.
    + * Tests for the behavior of the {@link BarrierBuffer} with {@link 
BufferSpiller}
      */
    -public class BarrierBufferTest {
    -
    -   private static final Random RND = new Random();
    -
    -   private static final int PAGE_SIZE = 512;
    -
    -   private static int sizeCounter = 0;
    +public class BarrierBufferTest extends BarrierBufferTestBase {
    --- End diff --
    
    Rename the test class name to `SpillingBarrierBufferTest`?


---

Reply via email to