[ 
https://issues.apache.org/jira/browse/FLINK-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362142#comment-16362142
 ] 

ASF GitHub Bot commented on FLINK-8475:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5459#discussion_r167831341
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
    @@ -127,7 +130,30 @@
         */
        public static final ConfigOption<String> DEFAULT_FILESYSTEM_SCHEME = 
ConfigOptions
                        .key("fs.default-scheme")
    -                   .noDefaultValue();
    +                   .noDefaultValue()
    +                   .withDescription("The default filesystem scheme, used 
for paths that do not declare a scheme explicitly.");
    --- End diff --
    
    Yes, in a practical sense "file:///" is the default due to how `FileSystem` 
works. We can't define it as the official default at the moment because of OS 
compatibility, see LocalFileSystem:
    ```
    LOCAL_URI = OperatingSystem.isWindows() ? URI.create("file:/") : 
URI.create("file:///");
    ```
    
    Not sure whether that is really necessary though, but the scheme parsing by 
`Paths` is a [bit wonky on 
Windows](https://issues.apache.org/jira/browse/FLINK-6889).


> Move remaining sections to generated tables
> -------------------------------------------
>
>                 Key: FLINK-8475
>                 URL: https://issues.apache.org/jira/browse/FLINK-8475
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Configuration
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to