GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5475
[FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in
ExecutionGraph
## What is the purpose of the change
This commit changes the initialization of the ExecutionGraph to use the
JobManagerOptions#SLOT_REQUEST_TIMEOUT for the slot allocation. Furthermore,
it changes the behaviour of the SlotPool#ProviderAndOwner implementation
such
that the timeout is given to it via the SlotProvider#allocateSlot call.
## Brief change log
- Don't start `SlotPool#ProviderAndOwner` with slot allocation timeout.
Instead require it as a parameter of `SlotProvider#allocateSlot`
- Pass in `JobManagerOptions#SLOT_REQUEST_TIMEOUT` to `ExecutionGraph` as
allocation timeout
## Verifying this change
This change is already covered by existing tests, such as `SlotPoolTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink slotAllocationTimeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5475
----
commit fd297f0fbdbd9b3302d0654261519d6c84438234
Author: Till Rohrmann <trohrmann@...>
Date: 2018-02-13T11:41:44Z
[FLINK-8643] [flip6] Use JobManagerOptions#SLOT_REQUEST_TIMEOUT in
ExecutionGraph
This commit changes the initialization of the ExecutionGraph to use the
JobManagerOptions#SLOT_REQUEST_TIMEOUT for the slot allocation. Furthermore,
it changes the behaviour of the SlotPool#ProviderAndOwner implementation
such
that the timeout is given to it via the SlotProvider#allocateSlot call.
commit 9162a5b7226665a4ae87cfde4271cf5e1d70d068
Author: Till Rohrmann <trohrmann@...>
Date: 2018-02-13T12:18:01Z
[hotfix] [flip6] Remove unnecessary timeout from SlotPool
----
---
