Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r167527566
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
 ---
    @@ -87,41 +86,12 @@ public boolean isFullBuffer() {
        SerializationResult setNextBufferBuilder(BufferBuilder bufferBuilder) 
throws IOException;
    --- End diff --
    
    One remark from reading the code, I found it a bit surprising that a method 
that looks like a setter will case the write to continue. Maybe this is better 
called something like `continueWritingWithNextBufferBuilder` or split the 
setter from a `continueWrite` method?


---

Reply via email to