[ 
https://issues.apache.org/jira/browse/FLINK-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362791#comment-16362791
 ] 

ASF GitHub Bot commented on FLINK-8607:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5441#discussion_r167892881
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/CollectTableSink.java
 ---
    @@ -0,0 +1,116 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.client.gateway;
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.common.typeinfo.Types;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.api.java.typeutils.TupleTypeInfo;
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +import org.apache.flink.streaming.experimental.CollectSink;
    +import org.apache.flink.streaming.experimental.SocketStreamIterator;
    +import org.apache.flink.table.client.SqlClientException;
    +import org.apache.flink.table.sinks.RetractStreamTableSink;
    +import org.apache.flink.table.sinks.TableSink;
    +import org.apache.flink.types.Row;
    +
    +import java.io.IOException;
    +import java.net.InetAddress;
    +import java.util.Iterator;
    +
    +/**
    + * Table sink for collecting the results locally.
    + */
    +public class CollectTableSink implements RetractStreamTableSink<Row>, 
Iterator<Tuple2<Boolean, Row>> {
    +
    +   private final InetAddress gatewayAddress;
    +   private final int manualGatewayPort;
    +
    +   private String[] fieldNames;
    +   private TypeInformation<?>[] fieldTypes;
    +   private SocketStreamIterator<Tuple2<Boolean, Row>> iterator;
    +
    +   public CollectTableSink(InetAddress gatewayAddress, int 
manualGatewayPort) {
    +           this.gatewayAddress = gatewayAddress;
    +           this.manualGatewayPort = manualGatewayPort;
    +   }
    +
    +   @Override
    +   public String[] getFieldNames() {
    +           return fieldNames;
    +   }
    +
    +   @Override
    +   public TypeInformation<?>[] getFieldTypes() {
    +           return fieldTypes;
    +   }
    +
    +   @Override
    +   public TableSink<Tuple2<Boolean, Row>> configure(String[] fieldNames, 
TypeInformation<?>[] fieldTypes) {
    +           this.fieldNames = fieldNames;
    +           this.fieldTypes = fieldTypes;
    +           return this;
    --- End diff --
    
    According to the JavaDocs `TableSink.configure()` must return a configured 
copy of the `TableSink` and not the `TableSink` object itself.


> Add a basic embedded SQL CLI client
> -----------------------------------
>
>                 Key: FLINK-8607
>                 URL: https://issues.apache.org/jira/browse/FLINK-8607
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>
> This issue describes the Implementation Plan 1 of FLIP-24.
> Goal: Add the basic features to play around with Flink's streaming SQL.
> {code}
> - Add CLI component that reads the configuration files
>     - "Pre-registered table sources"
>     - "Job parameters"
> - Add executor for retrieving pre-flight information and corresponding CLI 
> SQL parser
>     - SHOW TABLES
>     - DESCRIBE TABLE
>     - EXPLAIN
> - Add streaming append query submission to executor
> - Submit jars and run SELECT query using the ClusterClient
> - Collect results on heap and serve them on the CLI side (Internal Mode with 
> SELECT)
> - SOURCE (for executing a SQL statement stored in a local file)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to