[ 
https://issues.apache.org/jira/browse/FLINK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363289#comment-16363289
 ] 

ASF GitHub Bot commented on FLINK-8648:
---------------------------------------

GitHub user tweise opened a pull request:

    https://github.com/apache/flink/pull/5480

    [FLINK-8648] [kinesis] Allow for customization of emitRecordAndUpdateState 
in Kinesis connector.

    ## What is the purpose of the change
    
    Allow customization of record emission in the Kinesis consumer. In this 
case we will use it to implement custom watermark logic but it could also be 
used for any other logic that inspects the record with contextual information 
about the shard.
    
    ## Brief change log
    
    - Trivial change to remove final from the declaration to enable override.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    I didn't add a test, but perhaps we can add a NOOP example with override in 
the test package just to have the compile path covered?
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / *no*)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / *no*)
      - The serializers: (yes / *no* / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / *no* 
/ don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / *no* / don't know)
      - The S3 file system connector: (yes / *no* / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / *no*)
      - If yes, how is the feature documented? (*not applicable* / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/flink 
FLINK-8648.emitRecordAndUpdateState

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5480
    
----
commit c9b6369796cfa03448a1da32313981c581304a4b
Author: Thomas Weise <thw@...>
Date:   2018-02-14T00:33:59Z

    [FLINK-8648] [kinesis] Allow for customization of emitRecordAndUpdateState 
in Kinesis connector.

----


> Allow for customization of emitRecordAndUpdateState in Kinesis connector
> ------------------------------------------------------------------------
>
>                 Key: FLINK-8648
>                 URL: https://issues.apache.org/jira/browse/FLINK-8648
>             Project: Flink
>          Issue Type: Task
>          Components: Kinesis Connector
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Minor
>
> It should be possible to override the method to intercept the emit behavior, 
> in this case for the purpose of custom watermark support.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to