Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r168168634
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ---
    @@ -104,10 +107,8 @@
        @Nullable
        private OptionsFactory optionsFactory;
     
    -   /** True if incremental checkpointing is enabled.
    -    * Null if not yet set, in which case the configuration values will be 
used. */
    -   @Nullable
    -   private Boolean enableIncrementalCheckpointing;
    +   /** True if incremental checkpointing is enabled. */
    +   private TernaryBoolean enableIncrementalCheckpointing;
    --- End diff --
    
    I think by convention, the `is` should not be part of a boolean field name, 
only replace the `get` in the getter.


---

Reply via email to