[ 
https://issues.apache.org/jira/browse/FLINK-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364008#comment-16364008
 ] 

ASF GitHub Bot commented on FLINK-8647:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5478#discussion_r168171127
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ---
    @@ -698,7 +707,7 @@ else if (numConsumers == 0) {
                                        executor);
     
                                // double check to resolve race conditions
    -                           if(consumerVertex.getExecutionState() == 
RUNNING){
    +                           if (consumerVertex.getExecutionState() == 
RUNNING){
                                        consumerVertex.sendPartitionInfos();
    --- End diff --
    
    Good catch @zhangminglei. Will fix it.


> Introduce JobMasterConfiguration
> --------------------------------
>
>                 Key: FLINK-8647
>                 URL: https://issues.apache.org/jira/browse/FLINK-8647
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{JobMaster}} already contains some configuration settings which we pass 
> as constructor arguments. In order to make it better maintainable, I suggest 
> to add a {{JobMasterConfiguration}} object similar to the 
> {{TaskManagerConfiguration}}. This object will contain all {{JobMaster}} 
> specific configuration settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to