Till Rohrmann commented on FLINK-8641:

The alternative would be to pass the command template to 
{{BootstrapTools#getTaskManagerShellCommand}} right? This might even be the 
more general solution if we assume that at some point we might want to start 
{{TaskManagers}} in a different scenario than {{Yarn}}.

> Move BootstrapTools#getTaskManagerShellCommand to flink-yarn
> ------------------------------------------------------------
>                 Key: FLINK-8641
>                 URL: https://issues.apache.org/jira/browse/FLINK-8641
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, YARN
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Priority: Critical
> I would like to move {{getTaskManagerShellCommand()}} and 
> {{getStartCommand()}} from 
> {{org.apache.flink.runtime.clusterframework.BootstrapTools}} in flink-runtime 
> to flink-yarn.
> Yarn is the sole user of these methods, and both methods are directly related 
> to the {{YARN_CONTAINER_START_COMMAND_TEMPLATE}} {{ConfigConstants}}
> We can't move this constant to {{YarnOptions}} at this point since the 
> {{YarnOptions}} are in {{flink-yarn}}, but the above methods require the 
> option to be accessible from {{flink-runtime}}.
> [~till.rohrmann] Do you see any problems that this move could cause?

This message was sent by Atlassian JIRA

Reply via email to