[ 
https://issues.apache.org/jira/browse/FLINK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364061#comment-16364061
 ] 

ASF GitHub Bot commented on FLINK-8600:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/5486

    [FLINK-8600] Don't use flaky truncate() test in BucketingSink

    R: @kl0u 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink 
jira-8600-bucketing-sink-truncate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5486
    
----
commit 4ca30f33f297d66ae5008226eb5d80936e68d887
Author: Aljoscha Krettek <aljoscha.krettek@...>
Date:   2018-02-14T13:48:22Z

    [FLINK-8600] Don't use flaky truncate() test in BucketingSink
    
    The test was failing when using PrestoS3FileSystem because it doesn't
    use an absolute/qualified path. The test was questionable anyways
    because it tries writing to a random path that might not be writable by
    the user.
    
    This replaces the check with an explicit configuration setting for
    enabling/disabling truncate() support.

----


> BucketingSink errors out when used with Presto filesystem
> ---------------------------------------------------------
>
>                 Key: FLINK-8600
>                 URL: https://issues.apache.org/jira/browse/FLINK-8600
>             Project: Flink
>          Issue Type: Bug
>          Components: FileSystem
>    Affects Versions: 1.4.0
>            Reporter: Narayanan Arunachalam
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> BucketingSink passes a non-qualified path when attempting to test the 
> truncate behavior as you can see 
> [here|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java#L606].
> Because of thisĀ "Path is not absolute: uuid" error is thrown when used with 
> the 
> [PrestoS3FileSystem|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to