[ 
https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364074#comment-16364074
 ] 

ASF GitHub Bot commented on FLINK-8212:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5458#discussion_r168180756
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -270,10 +273,14 @@ public static TaskManagerServices fromConfiguration(
         * Creates a {@link MemoryManager} from the given {@link 
TaskManagerServicesConfiguration}.
         *
         * @param taskManagerServicesConfiguration to create the memory manager 
from
    +    * @param freeHeapMemoryWithDefrag an estimate of the size of the free 
heap memory
    +    * @param maxJvmHeapMemory the maximum JVM heap size
         * @return Memory manager
         * @throws Exception
         */
    -   private static MemoryManager 
createMemoryManager(TaskManagerServicesConfiguration 
taskManagerServicesConfiguration) throws Exception {
    +   private static MemoryManager 
createMemoryManager(TaskManagerServicesConfiguration 
taskManagerServicesConfiguration,
    +                                                                           
                         long freeHeapMemoryWithDefrag,
    +                                                                           
                         long maxJvmHeapMemory) throws Exception {
    --- End diff --
    
    Will fix ~


> Pull EnvironmentInformation out of TaskManagerServices
> ------------------------------------------------------
>
>                 Key: FLINK-8212
>                 URL: https://issues.apache.org/jira/browse/FLINK-8212
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime, Network
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should pull the {{EnvironmentInformation}} out of the 
> {{TaskManagerServices}} where it is used to get access to the memory settings 
> of the executing JVM. This unnecessarily couples the former with the latter 
> and makes testing extremely hard (one has to use {{PowerMockRunner}} and mock 
> the static {{EnvironmentInformation}}).
> When addressing this issue, then we should also refactor 
> {{NetworkBufferCalculationTest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to