ASF GitHub Bot commented on FLINK-8605:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: 
    @@ -593,6 +617,8 @@ public void shutdown(Time timeout) {
                } catch (Exception e) {
                        log.warn("Error while stopping leaderElectionService", 
    +           super.shutdown(timeout);
    --- End diff --
    Because `leaderElectionService.stop()` can call `revokeLeadership`. Inside 
of `revokeLeadership` we call `RestServerEndpoint#getRestAddress` which cannot 
be accessed after it has been shut down. This happens when calling 
`super.shutdown`. Moreover, I think it is a good idea to call the close method 
first on the sub class and then on the parent class in order to guarantee that 
you don't close any services from the parent class which the sub class might 
still need for closing.

> Enable job cancellation from the web UI
> ---------------------------------------
>                 Key: FLINK-8605
>                 URL: https://issues.apache.org/jira/browse/FLINK-8605
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
> In order to enable the job cancellation from the web UI (including YARN) we 
> have to register the {{JobTerminationHandler}} under 
> {{/jobs/:jobId/yarn-cancel}} and {{/jobs/:jobid/yarn-stop}}.

This message was sent by Atlassian JIRA

Reply via email to