[ 
https://issues.apache.org/jira/browse/FLINK-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616668#comment-14616668
 ] 

ASF GitHub Bot commented on FLINK-2288:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/886#discussion_r34037018
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/FlinkZooKeeperQuorumPeer.java
 ---
    @@ -0,0 +1,227 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.zookeeper;
    +
    +import org.apache.flink.api.java.utils.ParameterTool;
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.IllegalConfigurationException;
    +import org.apache.zookeeper.server.ServerConfig;
    +import org.apache.zookeeper.server.ZooKeeperServer;
    +import org.apache.zookeeper.server.ZooKeeperServerMain;
    +import org.apache.zookeeper.server.quorum.QuorumPeer;
    +import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
    +import org.apache.zookeeper.server.quorum.QuorumPeerMain;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +import java.io.FileInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.PrintWriter;
    +import java.util.Map;
    +import java.util.Properties;
    +import java.util.UUID;
    +
    +/**
    + * Simple wrapper for ZooKeeper's {@link QuorumPeer}, which reads a 
ZooKeeper config file and writes
    + * the required 'myid' file before starting the peer.
    + */
    +public class FlinkZooKeeperQuorumPeer {
    +
    +   private static final Logger LOG = 
LoggerFactory.getLogger(FlinkZooKeeperQuorumPeer.class);
    +
    +   public static void main(String[] args) {
    +           try {
    +                   final ParameterTool params = 
ParameterTool.fromArgs(args);
    --- End diff --
    
    JobManager and TaskManager log environment information. That helps a lot in 
debugging setups. This should log the environment info as well, via 
`EnvironmentInformation.logEnvironmentInfo(LOG, "FlinkZooKeeperQuorumPeer", 
args)`.


> Setup ZooKeeper for distributed coordination
> --------------------------------------------
>
>                 Key: FLINK-2288
>                 URL: https://issues.apache.org/jira/browse/FLINK-2288
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, TaskManager
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>             Fix For: 0.10
>
>
> Having standby JM instances for job manager high availabilty requires 
> distributed coordination between JM, TM, and clients. For this, we will use 
> ZooKeeper (ZK).
> Pros:
> - Proven solution (other projects use it for this as well)
> - Apache TLP with large community, docs, and library with required "recipies" 
> like leader election (see below)
> Related Wiki: 
> https://cwiki.apache.org/confluence/display/FLINK/JobManager+High+Availability



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to