[ 
https://issues.apache.org/jira/browse/FLINK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364278#comment-16364278
 ] 

ASF GitHub Bot commented on FLINK-8657:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5490

    Fix incorrect description in the document for externalized checkpoint…

    ## What is the purpose of the change
    
    This PR addressed issue 
[FLINK-8657](https://issues.apache.org/jira/browse/FLINK-8657). I checked that 
external checkpoint also supported rescale both in code and practice. But in 
the doc it still note that "do not support Flink specific features like 
rescaling."
    
    ## Brief change log
    
    - Fix incorrect description for externalized checkpoint vs savepoint.
    - Fix incorrect description for memory state backend.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink 
fix_doc_bug_for_externalized_checkpoint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5490
    
----
commit cf0bc52a36b4d65ac2a474f22efbddc8e46251c1
Author: summerleafs <summerleafs@...>
Date:   2018-02-14T15:21:02Z

    Fix incorrect description in the document for externalized checkpoints and 
memory state backend.

----


> Fix incorrect description for external checkpoint vs savepoint
> --------------------------------------------------------------
>
>                 Key: FLINK-8657
>                 URL: https://issues.apache.org/jira/browse/FLINK-8657
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.4.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> I checked that external checkpoint also supported rescale both in code and 
> practice. But in the doc it still note that "do not support Flink specific 
> features like rescaling." 
> I am afraid whether I have missed something, if so please just close this 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to