[ 
https://issues.apache.org/jira/browse/FLINK-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365644#comment-16365644
 ] 

ASF GitHub Bot commented on FLINK-5728:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5492
  
    Had to change this line to use `StreamingRuntimeContext.class` because the 
Producer would now actually call this: 
https://github.com/apache/flink/blob/96e898f2923f6b68bc845facf9c2d7ce1a951bbb/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java#L100
 😅 


> FlinkKafkaProducer should flush on checkpoint by default
> --------------------------------------------------------
>
>                 Key: FLINK-5728
>                 URL: https://issues.apache.org/jira/browse/FLINK-5728
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Major
>             Fix For: 1.5.0
>
>
> As discussed in FLINK-5702, it might be a good idea to let the 
> FlinkKafkaProducer flush on checkpoints by default. Currently, it is disabled 
> by default.
> It's a very simple change, but we should think about whether or not we want 
> to break user behaviour, or have proper usage migration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to