[
https://issues.apache.org/jira/browse/FLINK-8664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366087#comment-16366087
]
ASF GitHub Bot commented on FLINK-8664:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5496
[FLINK-8664] [rest] Change RpcEndpoint#TerminationFuture value type to Void
## What is the purpose of the change
Change `RpcEndpoint#TerminationFuture` value type to `Void`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink voidTerminationFuture
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5496
----
commit 1a077c7bb7d6240e86171dbbbd77e43668a7fe6c
Author: Till Rohrmann <trohrmann@...>
Date: 2018-02-15T17:43:39Z
[FLINK-8664] [rest] Change RpcEndpoint#TerminationFuture value type to Void
----
> Change termination future type of RpcEndpoint to Void
> -----------------------------------------------------
>
> Key: FLINK-8664
> URL: https://issues.apache.org/jira/browse/FLINK-8664
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to align the termination futures of {{RpcService}} and
> {{RpcEndpoint}} we should change the future value type of the
> {{RcpEnpoint#getTerminationFuture()}} to {{Void}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
