[ https://issues.apache.org/jira/browse/FLINK-8669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366795#comment-16366795 ]
ASF GitHub Bot commented on FLINK-8669: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5503 [FLINK-8669] Add completeAll and runAfterwards(Async) to FutureUtils ## What is the purpose of the change FutureUtils#completeAll(Collection) takes a collection of futures and returns a future which is completed after all of the given futures are completed. This also includes exceptional completions. Potentially occurring exceptions are recorded and combined into a single exception with which the resulting future is completed. FutureUtils#runAfterwards takes a future and runs a given action after the completion of the given future. This also includes an exceptional completion. In this case, a potentially occurring exception as the result of the provided action will be combined with the future's exception. ## Verifying this change - Added to `FutureUtils` `testCompleteAllExceptional`, `testCompleteAllPartialExceptional`, `testCompleteAll`, `testRunAfterwardsExceptional` and `testRunAfterwards` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink extendFutureUtils Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5503 ---- commit 51bb532d2490968635214016599475f91c5f97e5 Author: Till Rohrmann <trohrmann@...> Date: 2018-02-16T09:08:04Z [FLINK-8669] Add completeAll and runAfterwards(Async) to FutureUtils FutureUtils#completeAll(Collection) takes a collection of futures and returns a future which is completed after all of the given futures are completed. This also includes exceptional completions. Potentially occurring exceptions are recorded and combined into a single exception with which the resulting future is completed. FutureUtils#runAfterwards takes a future and runs a given action after the completion of the given future. This also includes an exceptional completion. In this case, a potentially occurring exception as the result of the provided action will be combined with the future's exception. ---- > Extend FutureUtils to have method to wait for the completion of all futures > --------------------------------------------------------------------------- > > Key: FLINK-8669 > URL: https://issues.apache.org/jira/browse/FLINK-8669 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > For proper non blocking shut down, we need some additional future methods > which allow to wait for the completion of a set of futures where each future > can fail. Moreover, it would be helpful to have a method to schedule > {{Runnables}} after the completion (potentially exceptional) of a future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)