Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r168717401
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskStateManagerImplTest.java
 ---
    @@ -148,22 +150,22 @@ public void 
testForwardingSubtaskLocalStateBaseDirFromLocalStateStore() throws I
                                taskLocalStateStore);
     
                        LocalRecoveryDirectoryProvider 
directoryProviderFromTaskLocalStateStore =
    -                           
taskLocalStateStore.createLocalRecoveryRootDirectoryProvider();
    +                           
taskLocalStateStore.getLocalRecoveryRootDirectoryProvider();
     
                        LocalRecoveryDirectoryProvider 
directoryProviderFromTaskStateManager =
                                
taskStateManager.createLocalRecoveryRootDirectoryProvider();
     
     
                        for (int i = 0; i < 10; ++i) {
                                Assert.assertEquals(rootDirs[i % 
rootDirs.length],
    -                                   
directoryProviderFromTaskLocalStateStore.nextRootDirectory());
    +                                   
directoryProviderFromTaskLocalStateStore.rootDirectory(i));
                                Assert.assertEquals(rootDirs[i % 
rootDirs.length],
    -                                   
directoryProviderFromTaskStateManager.nextRootDirectory());
    +                                   
directoryProviderFromTaskStateManager.rootDirectory(i));
                        }
     
    -                   Assert.assertEquals(
    -                           
directoryProviderFromTaskLocalStateStore.getSubtaskSpecificPath(),
    -                           
directoryProviderFromTaskStateManager.getSubtaskSpecificPath());
    +//                 Assert.assertEquals(
    +//                         
directoryProviderFromTaskLocalStateStore.getSubtaskSpecificPath(),
    +//                         
directoryProviderFromTaskStateManager.getSubtaskSpecificPath());
    --- End diff --
    
    removed in later commit


---

Reply via email to