[ 
https://issues.apache.org/jira/browse/FLINK-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367032#comment-16367032
 ] 

ASF GitHub Bot commented on FLINK-8671:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5506#discussion_r168752464
  
    --- Diff: docs/_includes/generated/job_manager_configuration.html ---
    @@ -9,67 +9,57 @@
         <tbody>
             <tr>
                 <td><h5>jobmanager.archive.fs.dir</h5></td>
    -            <td>(none)</td>
    +            <td style="word-wrap: break-word;">(none)</td>
                 <td></td>
             </tr>
             <tr>
                 <td><h5>jobmanager.execution.attempts-history-size</h5></td>
    -            <td>16</td>
    +            <td style="word-wrap: break-word;">16</td>
                 <td>The maximum number of prior execution attempts kept in 
history.</td>
             </tr>
             <tr>
                 <td><h5>jobmanager.execution.failover-strategy</h5></td>
    -            <td>"full"</td>
    +            <td style="word-wrap: break-word;">"full"</td>
                 <td>The maximum number of prior execution attempts kept in 
history.</td>
             </tr>
             <tr>
                 <td><h5>jobmanager.heap.mb</h5></td>
    -            <td>1024</td>
    +            <td style="word-wrap: break-word;">1024</td>
                 <td>JVM heap size (in megabytes) for the JobManager.</td>
             </tr>
             <tr>
                 <td><h5>jobmanager.resourcemanager.reconnect-interval</h5></td>
    -            <td>2000</td>
    +            <td style="word-wrap: break-word;">2000</td>
                 <td>This option specifies the interval in order to trigger a 
resource manager reconnection if the connection to the resource manager has 
been lost. This option is only intended for internal use.</td>
             </tr>
             <tr>
                 <td><h5>jobmanager.rpc.address</h5></td>
    -            <td>(none)</td>
    +            <td style="word-wrap: break-word;">(none)</td>
                 <td>The config parameter defining the network address to 
connect to for communication with the job manager. This value is only 
interpreted in setups where a single JobManager with static name or address 
exists (simple standalone setups, or container setups with dynamic service name 
resolution). It is not used in many high-availability setups, when a 
leader-election service (like ZooKeeper) is used to elect and discover the 
JobManager leader from potentially multiple standby JobManagers.</td>
             </tr>
             <tr>
                 <td><h5>jobmanager.rpc.port</h5></td>
    -            <td>6123</td>
    +            <td style="word-wrap: break-word;">6123</td>
                 <td>The config parameter defining the network port to connect 
to for communication with the job manager. Like jobmanager.rpc.address, this 
value is only interpreted in setups where a single JobManager with static 
name/address and port exists (simple standalone setups, or container setups 
with dynamic service name resolution). This config option is not used in many 
high-availability setups, when a leader-election service (like ZooKeeper) is 
used to elect and discover the JobManager leader from potentially multiple 
standby JobManagers.</td>
             </tr>
             <tr>
                 <td><h5>jobstore.cache-size</h5></td>
    -            <td>52428800</td>
    +            <td style="word-wrap: break-word;">52428800</td>
                 <td>The job store cache size in bytes which is used to keep 
completed jobs in memory.</td>
             </tr>
             <tr>
                 <td><h5>jobstore.expiration-time</h5></td>
    -            <td>3600</td>
    +            <td style="word-wrap: break-word;">3600</td>
                 <td>The time in seconds after which a completed job expires 
and is purged from the job store.</td>
             </tr>
    -        <tr>
    -            <td><h5>slot.allocation.resourcemanager.timeout</h5></td>
    -            <td>300000</td>
    -            <td>The timeout in milliseconds for allocation a slot from 
Resource Manager.</td>
    -        </tr>
             <tr>
                 <td><h5>slot.idle.timeout</h5></td>
    -            <td>300000</td>
    +            <td style="word-wrap: break-word;">20000</td>
                 <td>The timeout in milliseconds for a idle slot in Slot 
Pool.</td>
             </tr>
    -        <tr>
    -            <td><h5>slot.request.resourcemanager.timeout</h5></td>
    -            <td>10000</td>
    -            <td>The timeout in milliseconds for sending a request to 
Resource Manager.</td>
    -        </tr>
             <tr>
                 <td><h5>slot.request.timeout</h5></td>
    -            <td>600000</td>
    +            <td style="word-wrap: break-word;">300000</td>
    --- End diff --
    
    the default was recently updated


> Split documented default value if it is too long
> ------------------------------------------------
>
>                 Key: FLINK-8671
>                 URL: https://issues.apache.org/jira/browse/FLINK-8671
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> Default values that are a long continuous string mess up the configuration 
> table as we can see for the parent-first-patterns 
> [https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html#classloader-parent-first-patterns]
> The generator should chunk the stringified default value into chunks for 
> proper display.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to