[GitHub] flink pull request #5485: [FLINK-8411] Don't allow null in ListState.add()/a...

[kl0u]

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5485#discussion_r168765603
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/UserFacingListState.java
 ---
    @@ -48,6 +49,7 @@
     
        @Override
        public void add(T value) throws Exception {
    +           Preconditions.checkNotNull(value, "You cannot add null to a 
ListState.");
    --- End diff --
    
    You should also change the `addAll()`  to check for `nulls` internally, as 
done in the `HeapListState`.


---