Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5497#discussion_r168853239 --- Diff: docs/dev/migration.md --- @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction<Tuple2<String, Integer>>, bufferedElements.add(value); if (bufferedElements.size() == threshold) { for (Tuple2<String, Integer> element: bufferedElements) { - // send it to the sink - } - bufferedElements.clear(); - } + // send it to the sink + } + bufferedElements.clear(); --- End diff -- Ah, yes, @zentol you are right of course!
---