[
https://issues.apache.org/jira/browse/FLINK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368216#comment-16368216
]
ASF GitHub Bot commented on FLINK-8679:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5518
[FLINK-8679][State Backends]Fix RocksDBKeyedBackend.getKeys() bug for
missing namespace condition.
This PR addressed issue
[FLINK-8679](https://issues.apache.org/jira/browse/FLINK-8679). Currently,
`RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It doesn't use the
namespace to filter data. The lead to problematic when one key corresponding to
different namespace.
## Brief change log
- Modify RocksDBKeyedStateBackend.getKeys() to filter data according to
namespace.
## Verifying this change
- This change can be verified by unit test in
StateBackendTestBase.testGetKeys().
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink fix_rocksdb_getkeys
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5518
----
commit ec861f44c7dd9fb136fdc682154992f115288f77
Author: sihuazhou <summerleafs@...>
Date: 2018-02-16T17:26:12Z
Fix getKeys() in RocksDBKeyStateBackend.
commit 7b0069421aa4e484aba2a97db2e4c6b3cd88f058
Author: sihuazhou <summerleafs@...>
Date: 2018-02-17T02:29:59Z
Fix loop bug in `getKeys()`.
commit d50cf63a7da42ebcf5e6ad08e3bbe28b462b1f7c
Author: sihuazhou <summerleafs@...>
Date: 2018-02-17T14:13:14Z
add test case for different namespace.
----
> RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with
> namespace
> ------------------------------------------------------------------------------------
>
> Key: FLINK-8679
> URL: https://issues.apache.org/jira/browse/FLINK-8679
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Critical
>
> Currently, `RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It
> doesn't use the namespace to filter data. And
> `HeapKeyedBackend.getKeys(stateName, namespace)` has done that, I think they
> should be consistent at least.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
