[
https://issues.apache.org/jira/browse/FLINK-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368424#comment-16368424
]
ASF GitHub Bot commented on FLINK-8684:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5519
[FLINK-8684] [config] Rework MesosTaskManagerParameters#MESOS_RM_TASK…
## What is the purpose of the change
Directly by using ```TaskManagerOptions.NUM_TASK_SLOTS``` as it's alias to
rework the ```ConfigOption```. to avoid creating 2 documentation entries of
```taskmanager.numberOfTaskSlots```.
## Brief change log
Use FLINK-8683 test this change.
## Verifying this change
This change is a trivial rework.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): (/ no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (/ no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? ( not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-8684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5519
----
commit 2ea03310b29d69f56c637a2c367dad38c892c3ff
Author: zhangminglei <zml13856086071@...>
Date: 2018-02-18T03:01:39Z
[FLINK-8684] [config] Rework MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS
----
> Rework MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS
> ------------------------------------------------------
>
> Key: FLINK-8684
> URL: https://issues.apache.org/jira/browse/FLINK-8684
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Mesos
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Priority: Major
> Fix For: 1.5.0
>
>
> Currently, {{MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS}} mimics
> {{TaskManagerOptions#NUM_TASK_SLOTS}}:
> {code:java}
> public static final ConfigOption<Integer> MESOS_RM_TASKS_SLOTS =
> key(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS)
> .defaultValue(1);
> public static final ConfigOption<Integer> NUM_TASK_SLOTS =
> key("taskmanager.numberOfTaskSlots")
> .defaultValue(1)
> .withDescription("...");
> {code}
> This pattern is problematic as this creates 2 documentation entries for
> {{taskmanager.numberOfTaskSlots}} with different descriptions, and opens the
> potential for different defaults. Ultimately this causes the documentation to
> become ambiguous.
> I thus propose to either outright remove this option or turn it into an
> actual alias:
> {code:java}
> public static final ConfigOption<Integer> MESOS_RM_TASKS_SLOTS =
> TaskManagerOptions.NUM_TASK_SLOTS;
> {code}
> As a side-effect of FLINK-8683 we can ensure that no differing config options
> exist for a given key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
