Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5521#discussion_r169275364
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
    @@ -706,6 +700,9 @@ public void open(FileInputSplit fileSplit) throws 
IOException {
                        this.stream = isot.waitForCompletion();
                        this.stream = decorateInputStream(this.stream, 
fileSplit);
                }
    +           catch (FileNotFoundException e) {
    +                   throw new FileNotFoundException("Input split " + 
fileSplit.getPath() + " doesn't exist, skip and continue");
    +           }
    --- End diff --
    
    I would recommend including the text and stack of the caught ex, for the 
better stack trace. FNFEs can get raised in odd circumstances in S3; seeing the 
full stack is what you need when fielding support calls. eg.
    
    ```java
    throw new FileNotFoundException("Input split " + fileSplit.getPath() + " 
doesn't exist, skip and continue: " + e, e);
    ```


---

Reply via email to