Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5465#discussion_r169374194
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBMapState.java
 ---
    @@ -400,7 +410,7 @@ public UV setValue(UV value) {
        /** An auxiliary utility to scan all entries under the given key. */
        private abstract class RocksDBMapIterator<T> implements Iterator<T> {
     
    -           static final int CACHE_SIZE_BASE = 1;
    +           static final int CACHE_SIZE_BASE = 32;
    --- End diff --
    
    Indeed, I don't think the memory is really a concern (at least when 
CACHE_SIZE_LIMIT=128), I almost like to change the CACHE_SIZE to a fixed value 
(like 128), What do you think?


---

Reply via email to