[ https://issues.apache.org/jira/browse/FLINK-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371326#comment-16371326 ]
ASF GitHub Bot commented on FLINK-8728: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5541 [FLINK-8728] [flip6] Fail new worker requests immediately in standalone mode ## What is the purpose of the change Let the StandaloneResourceManager throw a ResourceManagerException in case that the SlotManager requests a new worker. ## Verifying this change - Added `StandaloneResourceManagerTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink standaloneFastResourceFailure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5541.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5541 ---- commit 5587dcaeee5915e5de5cfea387b7a8d37ff4a26e Author: Till Rohrmann <trohrmann@...> Date: 2018-02-21T11:21:58Z [FLINK-8728] [flip6] Fail new worker requests immediately in standalone mode Let the StandaloneResourceManager throw a ResourceManagerException in case that the SlotManager requests a new worker. ---- > Fail new worker requests immediately in Standalone mode > ------------------------------------------------------- > > Key: FLINK-8728 > URL: https://issues.apache.org/jira/browse/FLINK-8728 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In standalone mode, we should fail requests for new workers immediately, > because we know that we cannot start new workers. That way, we would not have > to wait for the pending slot request to time out. -- This message was sent by Atlassian JIRA (v7.6.3#76005)