Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169675799
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -123,214 +109,112 @@ public SavepointHandlers(@Nullable final String
defaultSavepointDir) {
/**
* HTTP handler to trigger savepoints.
*/
- public class SavepointTriggerHandler
- extends AbstractRestHandler<RestfulGateway,
SavepointTriggerRequestBody, SavepointTriggerResponseBody,
SavepointTriggerMessageParameters> {
+ public class SavepointTriggerHandler extends
TriggerHandler<RestfulGateway, SavepointTriggerRequestBody,
SavepointTriggerMessageParameters> {
public SavepointTriggerHandler(
- final CompletableFuture<String>
localRestAddress,
- final GatewayRetriever<? extends
RestfulGateway> leaderRetriever,
- final Time timeout,
- final Map<String, String> responseHeaders) {
+ CompletableFuture<String> localRestAddress,
--- End diff --
Unnecessary changes: `final` was fine and the indentation is off.
---
