[ 
https://issues.apache.org/jira/browse/FLINK-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371619#comment-16371619
 ] 

ASF GitHub Bot commented on FLINK-8632:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5451#discussion_r169687850
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/async/AsynchronousOperationResult.java
 ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.async;
    +
    +import 
org.apache.flink.runtime.rest.messages.queue.AsynchronouslyCreatedResource;
    +import org.apache.flink.runtime.rest.messages.queue.QueueStatus;
    +import org.apache.flink.util.Preconditions;
    +
    +import 
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
    +import 
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
    +
    +import javax.annotation.Nullable;
    +
    +/**
    + * Result of an asynchronous operation.
    + *
    + * @param <V> type of the result value
    + */
    +public class AsynchronousOperationResult<V> implements 
AsynchronouslyCreatedResource<V> {
    +
    +   private static final String FIELD_NAME_STATUS = "status";
    +
    +   private static final String FIELD_NAME_OPERATION = "operation";
    +
    +   @JsonProperty(FIELD_NAME_STATUS)
    +   private final QueueStatus queueStatus;
    +
    +   @JsonProperty(FIELD_NAME_OPERATION)
    +   @Nullable
    +   private final V value;
    +
    +   @JsonCreator
    +   private AsynchronousOperationResult(
    +           @JsonProperty(FIELD_NAME_STATUS) QueueStatus queueStatus,
    --- End diff --
    
    nit: indentation


> Generalize SavepointHandlers to be used for other asynchronous operations
> -------------------------------------------------------------------------
>
>                 Key: FLINK-8632
>                 URL: https://issues.apache.org/jira/browse/FLINK-8632
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> We should generalize the {{SavepointHandlers}} to be usable for other 
> asynchronous operations as well. The basic idea is that one has a trigger 
> handler which triggers an asynchronous operation. This operation returns a 
> future which is completed once the operation is done. The trigger handler 
> returns a trigger id which can be used to check the status of the operation 
> by querying the status handler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to