[
https://issues.apache.org/jira/browse/FLINK-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371807#comment-16371807
]
ASF GitHub Bot commented on FLINK-8645:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5544
Looks good to me.
Would be nice to have another opinion on the config key names. After all, I
just suggested my personal opinion...
> Support convenient extension of parent-first ClassLoader patterns
> -----------------------------------------------------------------
>
> Key: FLINK-8645
> URL: https://issues.apache.org/jira/browse/FLINK-8645
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
>
> The option {{classloader.parent-first-patterns}} defines a list of class
> pattern that should always be loaded through the parent class-loader. The
> default value contains all classes that are effectively required to be loaded
> that way for Flink to function.
> This list cannot be extended in a convenient way, as one would have to
> manually copy the existing default and append new entries. This makes the
> configuration brittle in light of version upgrades where we may extend the
> default, and also obfuscates the configuration a bit.
> I propose to separate this option into
> {{classloader.parent-first-patterns.base}}, which subsumes the existing
> option, and {{classloader.parent-first-patterns.append}} which is
> automatically appended to the base.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
