[
https://issues.apache.org/jira/browse/FLINK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372612#comment-16372612
]
ASF GitHub Bot commented on FLINK-8679:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5518#discussion_r169904243
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
---
@@ -61,8 +61,9 @@
* over it keys are not supported.
* @param state State variable for which existing keys will be returned.
* @param namespace Namespace for which existing keys will be returned.
+ * @param namespaceSerializer the serializer for the namespace.
*/
- <N> Stream<K> getKeys(String state, N namespace);
+ <N> Stream<K> getKeys(String state, N namespace, TypeSerializer<N>
namespaceSerializer);
--- End diff --
I noticed that introducing this additional parameter is actually not
required. It is only used in RocksDB, where we can also get the namespace
serializer in `getKeys(...)` via
```
Tuple2<ColumnFamilyHandle,
RegisteredKeyedBackendStateMetaInfo<?, ?>> columnInfo =
kvStateInformation.get(state);
if (columnInfo == null) {
return Stream.empty();
}
...
columnInfo.f1.getNamespaceSerializer();
```
> RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with
> namespace
> ------------------------------------------------------------------------------------
>
> Key: FLINK-8679
> URL: https://issues.apache.org/jira/browse/FLINK-8679
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Currently, `RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It
> doesn't use the namespace to filter data. And
> `HeapKeyedBackend.getKeys(stateName, namespace)` has done that, I think they
> should be consistent at least.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
