Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5518#discussion_r169905515
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -207,6 +208,9 @@
/** Unique ID of this backend. */
private UUID backendUID;
+ /** The byte array for namespace serialization in getKeys(). */
+ private final ByteArrayOutputStreamWithPos namespaceOutputStream;
--- End diff --
It feels like this member is in a too broad scope. While this maximizes
caching, I wonder if creating one of there per `getKeys(...)` all is not
cleaner and still efficient enough. What do you think?
---
