Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5518#discussion_r169989983
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -207,6 +208,9 @@
/** Unique ID of this backend. */
private UUID backendUID;
+ /** The byte array for namespace serialization in getKeys(). */
+ private final ByteArrayOutputStreamWithPos namespaceOutputStream;
--- End diff --
I would choose to create one of there per` getKeys(...)`.. I think it is
cleaner to me than put it into `RocksDBKeyedStateBackend`, cause it is only
used in `getKeys()` for now.
---
