Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r170038982
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskLocalStateStoreImplTest.java
 ---
    @@ -59,12 +59,18 @@ public void before() throws Exception {
                this.subtaskIdx = 0;
                this.rootDirs = new File[]{temporaryFolder.newFolder(), 
temporaryFolder.newFolder()};
     
    +           LocalRecoveryDirectoryProviderImpl directoryProvider =
    +                   new LocalRecoveryDirectoryProviderImpl(rootDirs, jobID, 
allocationID, jobVertexID, subtaskIdx);
    +
    +           LocalRecoveryConfig localRecoveryConfig =
    +                   new 
LocalRecoveryConfig(LocalRecoveryConfig.LocalRecoveryMode.DISABLED, 
directoryProvider);
    --- End diff --
    
    It's a bit strange that we have to pass in a `directoryProvider`, even 
though the `LocalRecoveryMode` is disabled. I think it would be better to have 
something like `LocalRecoveryConfig.disabled()` and 
`LocalRecoveryConfig.fileBased(directoryProvider)`.


---

Reply via email to