ASF GitHub Bot commented on FLINK-8538:

Github user xccui commented on a diff in the pull request:

    --- Diff: 
    @@ -43,7 +42,7 @@ object TableSourceFactoryService extends Logging {
       def findTableSourceFactory(descriptor: TableSourceDescriptor): 
TableSource[_] = {
    --- End diff --
    Rename to `findAndCreateTableSource()`?

> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>                 Key: FLINK-8538
>                 URL: https://issues.apache.org/jira/browse/FLINK-8538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should 
> be added. This issue includes improving the existing JSON descriptor with 
> validation that can be used for other connectors as well. It is up for 
> discussion if we want to split the KafkaJsonTableSource into connector and 
> format such that we can reuse the format for other table sources as well.

This message was sent by Atlassian JIRA

Reply via email to