[ 
https://issues.apache.org/jira/browse/FLINK-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374113#comment-16374113
 ] 

ASF GitHub Bot commented on FLINK-8451:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5567

    [FLINK-8451] [serializers] Make Scala tuple serializer deserialization more 
failure tolerant

    ## What is the purpose of the change
    
    Scala tuples (and thus also case classes) classes are serialized together 
with their serializers. The `serialVersionUID` changed from Scala 2.10 to 2.11. 
We need to ignore those changes when reading a serializer config snapshot.
    
    
    ## Brief change log
    
    - Make deserialization more failure tolerant
    
    ## Verifying this change
    
    - See `org.apache.flink.api.scala.runtime.TupleSerializerCompatibilityTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: yes
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / no)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-8451

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5567
    
----
commit 3855837fe3d79c473c59ad892daabbb45f711c47
Author: Timo Walther <twalthr@...>
Date:   2018-02-22T16:22:54Z

    [FLINK-8451] [serializers] Make Scala tuple serializer deserialization more 
failure tolerant

----


> CaseClassSerializer is not backwards compatible in 1.4
> ------------------------------------------------------
>
>                 Key: FLINK-8451
>                 URL: https://issues.apache.org/jira/browse/FLINK-8451
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.2
>
>
> There seems to be problems with the updated Scala version and the 
> CaseClassSerializer that make it impossible to restore from a Flink 1.3 
> savepoint.
> http://mail-archives.apache.org/mod_mbox/flink-user/201801.mbox/%3CCACk7FThV5itjSj_1fG9oaWS86z8WTKWs7abHvok6FnHzq9XT-A%40mail.gmail.com%3E
> http://mail-archives.apache.org/mod_mbox/flink-user/201801.mbox/%3C7CABB00B-D52F-4878-B04F-201415CEB658%40mediamath.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to