Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5403#discussion_r170260048
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
 ---
    @@ -1518,11 +1469,27 @@ void clear() {
                                Collection<TaskManagerLocation> 
preferredLocations) {
     
                        final SlotRequestId requestId = new SlotRequestId();
    +                   Collection<AllocationID> previousAllocationIDs = 
Collections.emptyList();
    +
    +                   // try to extract previous allocation ids, if 
applicable, so that we can reschedule to the same slot
    +                   Execution execution = task.getTaskToExecute();
    --- End diff --
    
    Don't let us couple the Execution with the `SlotPool`. Let's give the 
`SlotProfile` to this method instead.


---

Reply via email to