Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5564#discussion_r170229924
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
 ---
    @@ -89,37 +105,58 @@ class DescriptorProperties(normalizeKeys: Boolean = 
true) {
         put(key, clazz.getName)
       }
     
    +  /**
    +    * Adds a string under the given key.
    +    */
       def putString(key: String, str: String): Unit = {
         checkNotNull(key)
         checkNotNull(str)
         put(key, str)
       }
     
    +  /**
    +    * Adds a boolean under the given key.
    +    */
       def putBoolean(key: String, b: Boolean): Unit = {
         checkNotNull(key)
         put(key, b.toString)
       }
     
    +  /**
    +    * Adds a long under the given key.
    +    */
       def putLong(key: String, l: Long): Unit = {
         checkNotNull(key)
         put(key, l.toString)
       }
     
    +  /**
    +    * Adds an integer under the given key.
    +    */
       def putInt(key: String, i: Int): Unit = {
         checkNotNull(key)
         put(key, i.toString)
       }
     
    +  /**
    +    * Adds a character under the given key.
    +    */
       def putCharacter(key: String, c: Character): Unit = {
         checkNotNull(key)
         checkNotNull(c)
         put(key, c.toString)
       }
     
    +  /**
    +    * Adds a table schema under the given key.
    +    */
       def putTableSchema(key: String, schema: TableSchema): Unit = {
         putTableSchema(key, normalizeTableSchema(schema))
       }
     
    +  /**
    +    * Adds a table schema under the given key.
    +    */
       def putTableSchema(key: String, nameAndType: Seq[(String, String)]): 
Unit = {
    --- End diff --
    
    Remove?


---

Reply via email to